GitLab

update ACGCommon.cmake

See merge request !12

Windows ci

See merge request !11

This reverts commit c7a1e5cd.

This allows assigning property values even if the property type is
unknown, e.g. when iterating over mesh properties.

Motivation: avoid OpenFlipper crash when saving meshes with unsupported
properties.

Track if garbage collection is necessary.

This is useful for precondition checks in client code.

PR includes the bugfix from !5

See merge request !6

This is useful for precondition checks in client code.

Fix deferred vertex deletion, add unit tests.

GeometryKernel::collect_garbage used to first perform the TopologyKernel
garbage collection, usually shrinking its vertex_deleted_ member, then
accessed it using is_deleted() with the old vertex indices.

This caused out-of-bounds memory access (made visible by
cmake -DSTL_VECTOR_CHECKS=ON) and non-fast deletion also resulted in wrong
results, the remaining vertices had wrong coordinates.

See merge request !4

GeometryKernel::collect_garbage used to first perform the TopologyKernel
garbage collection, usually shrinking its vertex_deleted_ member, then
accessed it using is_deleted() with the old vertex indices.

This caused out-of-bounds memory access (made visible by
cmake -DSTL_VECTOR_CHECKS=ON) and non-fast deletion also resulted in wrong
results, the remaining vertices had wrong coordinates.