OpenMesh issueshttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues2017-06-30T13:25:18Zhttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/45Possible importer Bug?2017-06-30T13:25:18ZJan Möbiusmoebius@cs.rwth-aachen.dePossible importer Bug?Können Sie folgenden Bug bestätigen oder widerlegen:
Wir vermuten, dass in OpenMesh/Core/IO/importer/ImporterT.hh in der Funktion
virtual FaceHandle add_face(const VHandles& _indices)
folgende Zeile 160:
FaceHandle fh = me...Können Sie folgenden Bug bestätigen oder widerlegen:
Wir vermuten, dass in OpenMesh/Core/IO/importer/ImporterT.hh in der Funktion
virtual FaceHandle add_face(const VHandles& _indices)
folgende Zeile 160:
FaceHandle fh = mesh_.add_face(vhandles);
durch diese zu ersetzen ist:
fh = mesh_.add_face(vhandles);
Dh. soll die FaceHandle fh des darüberliegenden Scopes überschrieben werden?
Dann würde die Funktion eine gültige FaceHandle zurückgeben.OpenMesh 7.0Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/48Copy constructor adding face status twice?2017-11-08T10:18:45ZJan Möbiusmoebius@cs.rwth-aachen.deCopy constructor adding face status twice?Konkret tritt das Problem beim Löschen der face properties auf.
Ich habe den Verdacht, dass eine doppelte face status property die Ursache für das Problem ist.
Nach meiner Einschätzgun erzeugt der copy constructor eines tri mesh erzeug...Konkret tritt das Problem beim Löschen der face properties auf.
Ich habe den Verdacht, dass eine doppelte face status property die Ursache für das Problem ist.
Nach meiner Einschätzgun erzeugt der copy constructor eines tri mesh erzeugt die face status property doppelt:
IGM::TriMesh triMesh(quadMesh);
Der status property ist bereits vorhanden, jedoch ist der Referenzzähler auf 0 gesetzt, so dass diese doppelt
erzeugt wird.OpenMesh 7.0Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/49OBJ Writer UV Coordinates2017-10-26T10:24:30ZJan Möbiusmoebius@cs.rwth-aachen.deOBJ Writer UV CoordinatesHallo!
Die UV coordinaten werden nicht richtig geschrieben:
```
=======================================
diff --git a/src/OpenMesh/Core/IO/writer/OBJWriter.cc
b/src/OpenMesh/Core/IO/writer/OBJWriter.cc
index 66cf3b3f..698e8bae 100644
...Hallo!
Die UV coordinaten werden nicht richtig geschrieben:
```
=======================================
diff --git a/src/OpenMesh/Core/IO/writer/OBJWriter.cc
b/src/OpenMesh/Core/IO/writer/OBJWriter.cc
index 66cf3b3f..698e8bae 100644
--- a/src/OpenMesh/Core/IO/writer/OBJWriter.cc
+++ b/src/OpenMesh/Core/IO/writer/OBJWriter.cc
@@ -363,1 +363,1 @@
write(std::ostream&·_out, BaseExporter& _be, Options
_opt, std::streamsize _prec
{
// write vertex texture coordinate index
if (_opt.check(Options::VertexTexCoord))
- _out << texMap[_be.texcoord(vh)];
+ _out << texMap[_be.texcoord(vhandles[j])];
}
// write vertex normal index
```OpenMesh 7.0Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/50Standard Properties after Assignment2018-03-19T15:21:26ZMax Lyonlyon@cs.rwth-aachen.deStandard Properties after AssignmentIf a mesh which has standard properties is assigned a mesh which does not, the former will have no standard properties (as expected, I guess) but a positive ref count. When standard properties are than requested, they are not created due...If a mesh which has standard properties is assigned a mesh which does not, the former will have no standard properties (as expected, I guess) but a positive ref count. When standard properties are than requested, they are not created due to that positive ref count. Only for the four status properties does this work.
I added a unit test in da81dbaffa3222041c9edb42b8ad22ab38342afe for reproducibility.Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/51split_edge Creates Non-Triangular Faces on TriMeshes2018-10-30T09:20:21ZMax Lyonlyon@cs.rwth-aachen.desplit_edge Creates Non-Triangular Faces on TriMeshes```PolyConnectivity``` implements the two methods ```split_edge(EdgeHandle, VertexHandle)``` and ```split_edge_copy(EdgeHandle, VertexHandle)``` which split an edge without splitting the incident faces, thus increasing the valence of the...```PolyConnectivity``` implements the two methods ```split_edge(EdgeHandle, VertexHandle)``` and ```split_edge_copy(EdgeHandle, VertexHandle)``` which split an edge without splitting the incident faces, thus increasing the valence of the incident faces by one.
```TriConnectivity``` implements the two similar methods ```split(EdgeHandle, VertexHandle)``` and ```split_copy(EdgeHandle, VertexHandle)``` which do split the incident faces, thus performing a 2 to 4 split (or 1 to 2 split on boundaries) as expected.
Since ```TriConnectivity``` publicly inherits from ```PolyConnectivity```, ```split_edge``` can be called on a ```TriConnectivity``` resulting in non-triangular faces.
Should we add ```split_edge``` and ```split_edge_copy``` methods to ```TriConnectivity``` which call ```split``` and ```split_edge``` to prevent this?Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/52Move towards using free functions on built-in properties.2018-05-30T09:00:14ZChristian MattesMove towards using free functions on built-in properties.OpenMesh supports changing the type of the built-in properties (like the vertex position), which is a great feature.
For this to work however, the types have to implement certain methods such as `length()` and `normalize()` (as member m...OpenMesh supports changing the type of the built-in properties (like the vertex position), which is a great feature.
For this to work however, the types have to implement certain methods such as `length()` and `normalize()` (as member methods).
Replacing the calls to those methods by calls to free methods of the same name (and then implementing those free methods for the OpenMesh built-in Vectors as calls to the member) would make it easier to support new types for Points.
E.g. to use Eigen's Vector types with OpenMesh, it is currently required to use Eigen's "plugin" system, which can cause the program to fail in hard to debug ways.Christian MattesChristian Matteshttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/56Mention new OM python bindings in Documentation2018-12-06T08:20:56ZMartin HeistermannMention new OM python bindings in Documentationhttps://www.openmesh.org/Daily-Builds/Doc/a00036.html only describes the old python bindings, which can lead to confusion (see OM mailing list on 2016-06-08), I think we should (very visibly) refer to the new bindings there.https://www.openmesh.org/Daily-Builds/Doc/a00036.html only describes the old python bindings, which can lead to confusion (see OM mailing list on 2016-06-08), I think we should (very visibly) refer to the new bindings there.Isaak LimIsaak Limhttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/57Add SmartTagger to OpenMesh2018-10-30T09:20:21ZJan Möbiusmoebius@cs.rwth-aachen.deAdd SmartTagger to OpenMesh@born@bornOpenMesh 8.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/58Peristent Edge Properties2018-11-27T13:40:38ZMax Lyonlyon@cs.rwth-aachen.dePeristent Edge PropertiesThe om file format allows to store meshes together with custom properties. This does not work correctly for edge (and halfedge) properties.
The om file format stores explicitly only vertices and faces (as ordered set of vertices). When ...The om file format allows to store meshes together with custom properties. This does not work correctly for edge (and halfedge) properties.
The om file format stores explicitly only vertices and faces (as ordered set of vertices). When reading from a file, edges are created on the fly when they are needed for a face. This means that the edges in the loaded mesh may be in a different order than in the stored mesh.
Edge properties are stored and loaded in the same order. Thus, the loaded edge properties may not correspond to the edge.
I added a unittest which runs into this problem in commit 84eccff6a64a3749c0d01ff1f8a9b84d050c74cc.Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/59OpenMesh with Eigen2019-01-17T08:42:43ZJan Möbiusmoebius@cs.rwth-aachen.deOpenMesh with EigenWe had an issue with the interoperability of OpenMesh and Eigen because Eigen does not provide matrix constructors from a single value, while such constructors happen to be used (we found only two use cases) in OpenMesh.
Would you consi...We had an issue with the interoperability of OpenMesh and Eigen because Eigen does not provide matrix constructors from a single value, while such constructors happen to be used (we found only two use cases) in OpenMesh.
Would you consider fixing this ? Please find a patch implementing the changes in attachment.OpenMesh 8.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/60OBJ Writer/Reader Issue2019-01-15T14:07:52ZJan Möbiusmoebius@cs.rwth-aachen.deOBJ Writer/Reader IssueHi all,
I found an issue regarding the OBJ writer and saving Face TexCoords.
Basically, what I'm seeing is that the OBJ writer is adding extra vt entries into the OBJ file. The file still works in Meshlab if I add the missing MTL head...Hi all,
I found an issue regarding the OBJ writer and saving Face TexCoords.
Basically, what I'm seeing is that the OBJ writer is adding extra vt entries into the OBJ file. The file still works in Meshlab if I add the missing MTL header to the top of the OBJ file, but I'm unable to reopen the file using OpenMesh.
The error I'm getting is "Only single 2D or 3D texture coordinate per vertexallowed!". From what I'm seeing, the new OBJ file has (in my case) an additonal 983 VT entries.
To open the mesh, I'm doing:
OpenMesh::IO::Options ropt;
ropt += OpenMesh::IO::Options::FaceTexCoord;
_mesh.request_vertex_normals();
_mesh.request_face_normals();
_mesh.request_halfedge_texcoords2D();
if (!OpenMesh::IO::read_mesh(_mesh, path, ropt))
{
return false;
}
_mesh.update_normals();
To save the mesh, I'm doing:
OpenMesh::IO::Options wopt;
if (_mesh.has_vertex_normals())
{
wopt += OpenMesh::IO::Options::VertexNormal;
}
if (_mesh.has_halfedge_texcoords2D())
{
std::cout << "has 2d" << std::endl;
wopt += OpenMesh::IO::Options::FaceTexCoord;
}
if (!OpenMesh::IO::write_mesh(_mesh, path, wopt))
return true;
There have been no modifications to the file.OpenMesh 8.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/62Free functions for vector norm and others not found on gcc version greater or...2019-02-04T07:43:38ZJan Möbiusmoebius@cs.rwth-aachen.deFree functions for vector norm and others not found on gcc version greater or equal to 7.1OpenMesh 8.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.de2019-02-05https://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/63Warnings with gcc 8.22019-01-15T14:07:52ZJan Möbiusmoebius@cs.rwth-aachen.deWarnings with gcc 8.2OpenMesh 8.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/64PLY reader fix for ascii fix containing no endl2019-02-04T08:43:48ZJan Möbiusmoebius@cs.rwth-aachen.dePLY reader fix for ascii fix containing no endlThis patch fixes an error happening on ascii ply files without a newline at the end. To repro, remove the ending newline on a ply ascii file. I know it's a good practice to end text files with a newline, but for the PLY format where the ...This patch fixes an error happening on ascii ply files without a newline at the end. To repro, remove the ending newline on a ply ascii file. I know it's a good practice to end text files with a newline, but for the PLY format where the number of elements is specified, it seems unnecessary to be strict about this.OpenMesh 8.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/65Crash in subdivider after a vertex has been deleted2019-04-09T14:18:48ZJan Möbiusmoebius@cs.rwth-aachen.deCrash in subdivider after a vertex has been deletedOpenMesh 8.1Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/66heap-buffer-overflow while adding an invalid triangle face2021-01-29T11:08:44ZSven-Kristofer Pilzheap-buffer-overflow while adding an invalid triangle faceI came across a pathological mesh example that triggered a heap corruption in version %"OpenMesh 8.0".
The following is a minimal failing example, which will fail when run with *AddressSanitizer* (*heap-buffer-overflow* in ` OpenMesh::P...I came across a pathological mesh example that triggered a heap corruption in version %"OpenMesh 8.0".
The following is a minimal failing example, which will fail when run with *AddressSanitizer* (*heap-buffer-overflow* in ` OpenMesh::PolyConnectivity::add_face(OpenMesh::VertexHandle const*, unsigned long)`).
```cpp
#include <OpenMesh/Core/Mesh/PolyMesh_ArrayKernelT.hh>
typedef OpenMesh::PolyMesh_ArrayKernelT<> MyMesh;
int main()
{
MyMesh mesh;
const auto a = mesh.add_vertex(MyMesh::Point{-6.95757 -0.418557 -7.25885});
const auto b = mesh.add_vertex(MyMesh::Point{-7.03569 -0.128014 -7.26395});
mesh.add_face(a,b,a);
return 0;
}
```
When run with assertions enabled, this triggers:
> OpenMesh/Core/Mesh/PolyConnectivity.cc:272: OpenMesh::ArrayKernel::FaceHandle OpenMesh::PolyConnectivity
> ::add_face(const VertexHandle*, size_t): Assertion `boundary_prev.is_valid()' failed.https://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/67property visualizer, edge property visualization2019-08-07T13:30:09ZNicolas Gallego-Ortizproperty visualizer, edge property visualizationSystem: macOS 10.14.6, c++ compiler clang-1000.11.45.5, cmake 3.14.5,
Debug mode, using Qt Creator 4.9.2
Shader: pipeline render plugin, (although changing it does not change the behavior)
Hi all,
I just observed this unexpected be...System: macOS 10.14.6, c++ compiler clang-1000.11.45.5, cmake 3.14.5,
Debug mode, using Qt Creator 4.9.2
Shader: pipeline render plugin, (although changing it does not change the behavior)
Hi all,
I just observed this unexpected behavior when visualizing edge properties of meshes (OpenMesh) with the property visualization plugin. I the provided file there is a triangle mesh of a plane, and an edge property saved from it.
I get this error message on the console, and the mesh is rendered as a tube on the z-direction as shown in the image. The plane mesh can be seen after clicking on the object for a short time but the edges shown are not those of the original mesh.
I would be happy to help solve this issue, for now just let me know if you can reproduce it in other systems and some hints on where to start the debugging process.
Thanks,
Nicolas
```
GLError /Users/nicolas.gallego-ortiz/projects/OpenFlipper-072019/OpenFlipper/libs_required/ACG/ShaderUtils/GLSLShader.cc:650 - 1282
GLError /Users/nicolas.gallego-ortiz/projects/OpenFlipper-072019/OpenFlipper/libs_required/ACG/ShaderUtils/GLSLShader.cc:704 - 1282 - inColor
```
[mesh2.om](/uploads/7d19640750d0d63bac96123c433397d2/mesh2.om)
[kappa.eprop](/uploads/85cb68a117b9b3876525ecc5ce580307/kappa.eprop)
![screenshot](/uploads/086c07c3b29a4618be864f85cb6e206e/screenshot.png)https://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/68Lots of warnings2019-12-03T11:23:55ZJan Möbiusmoebius@cs.rwth-aachen.deLots of warningsOpenMesh/Core/Mesh/CirculatorsT.hh:319:49: warning: unused variable 'self' [-Wunused-variable]
const GenericCirculatorBaseT<Mesh>* self = this;
Also line 508 ...OpenMesh/Core/Mesh/CirculatorsT.hh:319:49: warning: unused variable 'self' [-Wunused-variable]
const GenericCirculatorBaseT<Mesh>* self = this;
Also line 508 ...OpenMesh 8.1Max Lyonlyon@cs.rwth-aachen.deMax Lyonlyon@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/69Tons of warnings on windows, clang, ...2021-01-25T14:59:07ZJan Möbiusmoebius@cs.rwth-aachen.deTons of warnings on windows, clang, ...DLL Warnings on Windows
Unused Variables ...DLL Warnings on Windows
Unused Variables ...OpenMesh 8.1Max Lyonlyon@cs.rwth-aachen.deMax Lyonlyon@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenMesh/OpenMesh/-/issues/71Docu pics broken2020-03-18T08:22:32ZJan Möbiusmoebius@cs.rwth-aachen.deDocu pics brokenJan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.de