Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
OpenMesh
OpenMesh
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenMesh
  • OpenMeshOpenMesh
  • Issues
  • #47

Closed
Open
Opened Sep 26, 2017 by Martin Schultz@schultzDeveloper

Binary STL Files are recogniced as ASCII

[...] in the function _STLReader_::check_stl_type() (STLReader.cc file) you assume that a STL is  encoded in ASCII format by looking for the keyword solid, i.e., line 476:

   //check for ascii keyword solid
   if(strnicmp("solid",&line[firstChar],5) == 0)
   {
     return STLA;
   }

The problem is that also some binary STL files start with the "solid" keyword, and it seems the standard allows it, at least looking at the first references I've found:

https://people.sc.fsu.edu/~jburkardt/data/stla/stla.html
https://people.sc.fsu.edu/~jburkardt/data/stlb/stlb.html

[...]

a workaround solution could be to look for the keyword "facet" in place of the keyword "solid" [...]

by Alberto Pretto

Related to: !83 (merged)

example file to trigger this issue: sportellino.stl

Edited Sep 26, 2017 by Martin Schultz
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: OpenMesh/OpenMesh#47