Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
OpenMesh
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
13
Issues
13
List
Boards
Labels
Service Desk
Milestones
Merge Requests
4
Merge Requests
4
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenMesh
OpenMesh
Commits
a7e96577
Commit
a7e96577
authored
Jan 17, 2019
by
Jan Möbius
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use vectorize for initializing vector in dummy implementations
closes
#59
parent
a5e04d48
Pipeline
#8268
failed with stage
in 20 minutes and 38 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
4 deletions
+21
-4
src/OpenMesh/Core/Geometry/EigenVectorT.hh
src/OpenMesh/Core/Geometry/EigenVectorT.hh
+1
-2
src/OpenMesh/Core/Mesh/PolyMeshT.cc
src/OpenMesh/Core/Mesh/PolyMeshT.cc
+20
-2
No files found.
src/OpenMesh/Core/Geometry/EigenVectorT.hh
View file @
a7e96577
...
...
@@ -89,9 +89,7 @@ namespace Eigen {
template
<
typename
Derived
>
MatrixBase
<
Derived
>
normalize
(
MatrixBase
<
Derived
>
&
x
)
{
std
::
cerr
<<
"Norm : "
<<
x
.
norm
()
<<
std
::
endl
;
x
/=
x
.
norm
();
std
::
cerr
<<
"Norm : "
<<
x
<<
std
::
endl
;
return
x
;
}
...
...
@@ -99,6 +97,7 @@ namespace Eigen {
MatrixBase
<
Derived
>
&
vectorize
(
MatrixBase
<
Derived
>
&
x
,
typename
Derived
::
Scalar
const
&
val
)
{
x
.
fill
(
val
);
std
::
cerr
<<
"Vec"
<<
std
::
endl
;
return
x
;
}
...
...
src/OpenMesh/Core/Mesh/PolyMeshT.cc
View file @
a7e96577
...
...
@@ -154,7 +154,15 @@ typename PolyMeshT<Kernel>::Normal
PolyMeshT
<
Kernel
>::
calc_face_normal_impl
(
FaceHandle
,
PointIsNot3DTag
)
const
{
// Dummy fallback implementation
return
Normal
(
typename
Normal
::
value_type
(
0
));
// Returns just an initialized all 0 normal
// This function is only used if we don't hate a matching implementation
// for normal computation with the current vector type defined in the mesh traits
assert
(
false
);
Normal
normal
;
vectorize
(
normal
,
0
);
return
normal
;
}
//-----------------------------------------------------------------------------
...
...
@@ -212,7 +220,17 @@ template <class Kernel>
typename
PolyMeshT
<
Kernel
>::
Normal
PolyMeshT
<
Kernel
>::
calc_face_normal_impl
(
const
Point
&
,
const
Point
&
,
const
Point
&
,
PointIsNot3DTag
)
const
{
return
Normal
(
typename
Normal
::
value_type
(
0
));
// Dummy fallback implementation
// Returns just an initialized all 0 normal
// This function is only used if we don't hate a matching implementation
// for normal computation with the current vector type defined in the mesh traits
assert
(
false
);
Normal
normal
;
vectorize
(
normal
,
0
);
return
normal
;
}
//-----------------------------------------------------------------------------
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment