cppcheck

CI/ci-cppcheck.sh

@@ -20,7 +20,7 @@ echo -e "${NC}"
 echo "Please Wait ..."
 
 # Run cppcheck and output into file
-cppcheck --enable=all . -I src -i Doc/ --force --suppress=unusedFunction -UCTIME --suppress=missingIncludeSystem --inline-suppr --quiet -Umin -Umax -DOPENMESHDLLEXPORT="" -UPRIVATE_NODE_TYPESYSTEM_SOURCE -USO_NODE_ABSTRACT_SOURCE -USO_NODE_SOURCE -UCLOCK_REALTIME_HR -i src/OpenMesh/Apps/Unsupported/  2>&1 | tee cppcheck.log
+cppcheck --enable=all . -I src -i Doc/ -i src/Unittests --force --suppress=unusedFunction -UCTIME --suppress=missingIncludeSystem --inline-suppr --quiet -Umin -Umax -DOPENMESHDLLEXPORT="" -UPRIVATE_NODE_TYPESYSTEM_SOURCE -USO_NODE_ABSTRACT_SOURCE -USO_NODE_SOURCE -UCLOCK_REALTIME_HR -i src/OpenMesh/Apps/Unsupported/  2>&1 | tee cppcheck.log
 
 COUNT=$(wc -l < cppcheck.log )
 
@@ -30,7 +30,7 @@ echo "CPPCHECK Summary"
 echo "=============================================================================="
 echo -e "${NC}"
 
-MAX_COUNT=0
+MAX_COUNT=100
 
 if [ $COUNT -gt $MAX_COUNT ]; then
   echo -e ${WARNING}

src/OpenMesh/Apps/Subdivider/MeshViewerWidget.hh

@@ -72,7 +72,7 @@ public:
    typedef MeshViewerWidgetT<Mesh> Base;
    
   /// default constructor
-  MeshViewerWidget(QWidget* _parent=0)
+  explicit MeshViewerWidget(QWidget* _parent=0)
     : Base(_parent)
   {}
 

src/OpenMesh/Apps/VDProgMesh/mkbalancedpm/mkbalancedpm.cc

@@ -107,7 +107,7 @@ public:
 
 public: // inherited
 
-  void initialize(void)
+  void initialize(void) override
   {
     BaseModQ::initialize();
     n_vertices_ = BaseModQ::mesh().n_vertices();

src/OpenMesh/Tools/Subdivider/Uniform/Composite/CompositeTraits.hh

@@ -86,6 +86,7 @@ struct CompositeTraits : public OpenMesh::DefaultTraits
 
   FaceTraits
   {
+
   private:
     typedef typename Refs::HalfedgeHandle HalfedgeHandle;
     typedef typename Refs::Scalar Scalar;

src/OpenMesh/Tools/Utils/HeapT.hh

@@ -351,12 +351,11 @@ HeapT<HeapEntry, HeapInterface>::
 downheap(size_t _idx)
 {
   const HeapEntry     h = entry(_idx);
-  size_t        childIdx;
   const size_t        s = size();
   
   while(_idx < s)
   {
-    childIdx = left(_idx);
+    size_t childIdx = left(_idx);
     if (childIdx >= s) break;
     
     if ((childIdx + 1 < s) && (interface_.less(entry(childIdx + 1), entry(childIdx))))