Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
OpenMesh
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
13
Issues
13
List
Boards
Labels
Service Desk
Milestones
Merge Requests
5
Merge Requests
5
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenMesh
OpenMesh
Commits
0e3491ed
Commit
0e3491ed
authored
Jan 26, 2018
by
Jan Möbius
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
obj exporter: fail if vertex color export was requested
parent
7856a437
Pipeline
#6087
passed with stage
in 73 minutes and 10 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
4 deletions
+15
-4
Doc/changelog.docu
Doc/changelog.docu
+1
-0
src/OpenMesh/Core/IO/writer/OBJWriter.cc
src/OpenMesh/Core/IO/writer/OBJWriter.cc
+14
-4
No files found.
Doc/changelog.docu
View file @
0e3491ed
...
...
@@ -53,6 +53,7 @@
<li>ImporterT: Modified the add_face function of importerT to always return a valid FaceHandle</li>
<li>ImporterT: Return a valid FaceHandle when adding non-manifold faces.</li>
<li>BaseExporter: Added accessor functions for HalfEdgeHandles and faceTexCoords to base exporter and exporter template.</li>
<li>OBJ Writer: Fail if vertex color export was requested (Thanks to Manuel Massing)</li>
<li>OBJ Writer: Added functionality to store FaceTexCoords to objwriter</li>
<li>OBJ Writer: Applied fix for bad or missing vertex tex coords (Thanks to Gero Müller for the patch)</li>>
<li>OBJ Loader: range check for vertex colors and normals in OBJ loader</li>
...
...
src/OpenMesh/Core/IO/writer/OBJWriter.cc
View file @
0e3491ed
...
...
@@ -224,12 +224,22 @@ write(std::ostream& _out, BaseExporter& _be, Options _opt, std::streamsize _prec
if
(
!
check
(
_be
,
_opt
))
return
false
;
// No binary mode for OBJ
if
(
_opt
.
check
(
Options
::
Binary
)
)
{
omout
()
<<
"[OBJWriter] : Warning, Binary mode requested for OBJ Writer (No support for Binary mode), falling back to standard."
<<
std
::
endl
;
}
// check writer features
if
(
_opt
.
check
(
Options
::
Binary
)
||
// not supported by format
_opt
.
check
(
Options
::
FaceNormal
))
return
false
;
// check for unsupported writer features
if
(
_opt
.
check
(
Options
::
FaceNormal
)
)
{
omerr
()
<<
"[OBJWriter] : FaceNormal not supported by OBJ Writer"
<<
std
::
endl
;
return
false
;
}
// check for unsupported writer features
if
(
_opt
.
check
(
Options
::
VertexColor
)
)
{
omerr
()
<<
"[OBJWriter] : VertexColor not supported by OBJ Writer"
<<
std
::
endl
;
return
false
;
}
//create material file if needed
if
(
_opt
.
check
(
Options
::
FaceColor
)
){
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment