Commit 46c2dd2a authored by Jan Möbius's avatar Jan Möbius

Silence some cppcheck warnings

parent 4ba6e989
......@@ -54,7 +54,7 @@ template <typename MeshT>
class OMPropertyVisualizerBoolean: public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerBoolean(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo);
OMPropertyVisualizerBoolean(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo);
virtual ~OMPropertyVisualizerBoolean(){}
protected:
......
......@@ -47,7 +47,7 @@
#include <ACG/Utils/ColorConversion.hh>
template <typename MeshT>
OMPropertyVisualizerBoolean<MeshT>::OMPropertyVisualizerBoolean(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo)
OMPropertyVisualizerBoolean<MeshT>::OMPropertyVisualizerBoolean(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo)
{
if (PropertyVisualizer::widget) delete PropertyVisualizer::widget;
......
......@@ -59,7 +59,7 @@ template <typename MeshT>
class OMPropertyVisualizerDouble: public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerDouble(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo);
OMPropertyVisualizerDouble(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo);
virtual ~OMPropertyVisualizerDouble(){}
protected:
......
......@@ -47,7 +47,7 @@
#include "OMPropertyVisualizerDouble.hh"
template <typename MeshT>
OMPropertyVisualizerDouble<MeshT>::OMPropertyVisualizerDouble(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo)
OMPropertyVisualizerDouble<MeshT>::OMPropertyVisualizerDouble(MeshT* _mesh, int _objectID,const PropertyInfo& _propertyInfo)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo)
{
if (PropertyVisualizer::widget) delete PropertyVisualizer::widget;
......
......@@ -56,7 +56,7 @@ template <typename MeshT, typename T>
class OMPropertyVisualizerInteger: public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerInteger(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo, bool isUnsigned);
OMPropertyVisualizerInteger(MeshT* _mesh, int _objectID,const PropertyInfo& _propertyInfo, bool isUnsigned);
virtual ~OMPropertyVisualizerInteger(){}
protected:
......
......@@ -48,7 +48,7 @@
#include "OMPropertyVisualizerInteger.hh"
template <typename MeshT, typename T>
OMPropertyVisualizerInteger<MeshT, T>::OMPropertyVisualizerInteger(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo, bool isUnsigned)
OMPropertyVisualizerInteger<MeshT, T>::OMPropertyVisualizerInteger(MeshT* _mesh, int _objectID,const PropertyInfo& _propertyInfo, bool isUnsigned)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo)
{
if (PropertyVisualizer::widget) delete PropertyVisualizer::widget;
......
......@@ -58,7 +58,7 @@ template <typename MeshT>
class OMPropertyVisualizerSkinWeights: public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerSkinWeights(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo);
OMPropertyVisualizerSkinWeights(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo);
virtual ~OMPropertyVisualizerSkinWeights(){}
protected:
......
......@@ -49,7 +49,7 @@
#include "OMPropertyVisualizerSkinWeights.hh"
template <typename MeshT>
OMPropertyVisualizerSkinWeights<MeshT>::OMPropertyVisualizerSkinWeights(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo)
OMPropertyVisualizerSkinWeights<MeshT>::OMPropertyVisualizerSkinWeights(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo)
{
if (PropertyVisualizer::widget) delete PropertyVisualizer::widget;
......
......@@ -51,7 +51,7 @@
namespace {
template <typename EntityType, typename Handle, typename MeshT>
QString getPropertyText__(Handle handle, MeshT mesh, PropertyInfo propInfo)
QString getPropertyText__(Handle handle, MeshT mesh, const PropertyInfo& propInfo)
{
EntityType prop;
......
......@@ -60,7 +60,7 @@ template <typename MeshT>
class OMPropertyVisualizerVector: public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerVector(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo);
OMPropertyVisualizerVector(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo);
virtual ~OMPropertyVisualizerVector(){clear();}
virtual void clear() override;
......
......@@ -60,7 +60,7 @@ template <typename MeshT, typename VectorType>
class OMPropertyVisualizerVector2 : public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerVector2(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo);
OMPropertyVisualizerVector2(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo);
virtual ~OMPropertyVisualizerVector2(){clear();}
void clear() override;
......
......@@ -47,7 +47,7 @@
#include <ACG/Utils/ColorConversion.hh>
template <typename MeshT, typename VectorType>
OMPropertyVisualizerVector2<MeshT, VectorType>::OMPropertyVisualizerVector2(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo)
OMPropertyVisualizerVector2<MeshT, VectorType>::OMPropertyVisualizerVector2(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo)
{
if (PropertyVisualizer::widget) delete PropertyVisualizer::widget;
......
......@@ -60,7 +60,7 @@ template <typename MeshT>
class OMPropertyVisualizerVectorFieldDifference: public OMPropertyVisualizer<MeshT>{
public:
OMPropertyVisualizerVectorFieldDifference(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo1, PropertyInfo _propertyInfo2);
OMPropertyVisualizerVectorFieldDifference(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo1, const PropertyInfo& _propertyInfo2);
virtual ~OMPropertyVisualizerVectorFieldDifference(){}
QString getName() override { return QObject::tr("Combination of %1 and %2").arg(PropertyVisualizer::propertyInfo.propName().c_str()).arg(propertyInfo2.propName().c_str()); }
......
......@@ -47,7 +47,7 @@
#include "OMPropertyVisualizerVectorFieldDifference.hh"
template <typename MeshT>
OMPropertyVisualizerVectorFieldDifference<MeshT>::OMPropertyVisualizerVectorFieldDifference(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo1, PropertyInfo _propertyInfo2)
OMPropertyVisualizerVectorFieldDifference<MeshT>::OMPropertyVisualizerVectorFieldDifference(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo1, const PropertyInfo& _propertyInfo2)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo1),
propertyInfo2(_propertyInfo2)
{
......
......@@ -47,7 +47,7 @@
#include <ACG/Utils/ColorConversion.hh>
template <typename MeshT>
OMPropertyVisualizerVector<MeshT>::OMPropertyVisualizerVector(MeshT* _mesh, int _objectID, PropertyInfo _propertyInfo)
OMPropertyVisualizerVector<MeshT>::OMPropertyVisualizerVector(MeshT* _mesh, int _objectID, const PropertyInfo& _propertyInfo)
: OMPropertyVisualizer<MeshT>(_mesh, _objectID, _propertyInfo)
{
if (PropertyVisualizer::widget) delete PropertyVisualizer::widget;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment