BoxesNode: improve bounding box calculation, mention remaining issue

1ed0bbec · Martin Heistermann · 1d530050 · 1ed0bbec
Commit 1ed0bbec authored May 14, 2019 by Martin Heistermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

Nodes/BoxesNode.cc Nodes/BoxesNode.cc +3 -2

No files found.
--- a/Nodes/BoxesNode.cc
+++ b/Nodes/BoxesNode.cc
@@ -98,9 +98,10 @@ void
 BoxesNode::
 boundingBox(Vec3d& _bbMin, Vec3d& _bbMax)
 {
+    // FIXME: this assumes matrices to only consist of vectors up to unit length
    for (const auto &be: elem_) {
-        _bbMax.maximize(be.pos + Vec3d(1.,1.,1.));
-        _bbMin.minimize(be.pos + Vec3d(-1., -1., -1.));
+        _bbMax.maximize(be.pos + Vec3d(scaleFactor_,scaleFactor_,scaleFactor_));
+        _bbMin.minimize(be.pos + Vec3d(-scaleFactor_, -scaleFactor_, -scaleFactor_));
    }
 }