Commit a960afbd authored by Jan Möbius's avatar Jan Möbius

Reduce cppcheck warnings

Added clang gtest 1.8 to sw repo
parent 7d51988e
......@@ -59,7 +59,7 @@ echo "CPPCHECK Summary"
echo "=============================================================================="
echo -e "${NC}"
MAX_ERROR=332
MAX_ERROR=311
if [ $COUNT -gt $MAX_ERROR ]; then
echo -e ${WARNING}
......
......@@ -24,7 +24,7 @@ if [ "$COMPILER" == "gcc" ]; then
elif [ "$COMPILER" == "clang" ]; then
OPTIONS="$OPTIONS -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DGTEST_PREFIX=~/sw/gtest-1.7.0-clang/ "
OPTIONS="$OPTIONS -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DGTEST_PREFIX=~/sw/gtest-1.8.0-clang/ "
# Build options with icecc /not working due to strange symbol errors
# OPTIONS="$OPTIONS -DCMAKE_CXX_COMPILER=/usr/lib/icecc/bin/g++ -DCMAKE_C_COMPILER=/usr/lib/icecc/bin/gcc -DGTEST_PREFIX=~/sw/gtest-1.7.0-clang/ "
......
......@@ -1177,7 +1177,7 @@ public:
/**
@param _desc description-set of shader properties.
*/
ShaderProgGenerator(const ShaderGenDesc* _desc);
explicit ShaderProgGenerator(const ShaderGenDesc* _desc);
/**
@param _desc description-set of shader properties.
......
......@@ -297,7 +297,7 @@ private:
}
public:
RingStack(unsigned int _uiSize) :
explicit RingStack(unsigned int _uiSize) :
uiStart(0),
uiLen(0),
uiSize(_uiSize)
......
......@@ -119,16 +119,16 @@ public:
Scalar _Dw, Scalar _Dx, Scalar _Dy, Scalar _Dz);
/// Construct from a rotation given as quaternion
DualQuaternionT(Quaternion _rotation);
explicit DualQuaternionT(Quaternion _rotation);
/// Construct from a translatation given as a vector
DualQuaternionT(const Vec3& _translation);
explicit DualQuaternionT(const Vec3& _translation);
/// Construct from a translation+rotation
DualQuaternionT(const Vec3& _translation, const Quaternion& _rotation);
/// Construct from a rigid transformation given as matrix
DualQuaternionT(const Matrix& _transformation);
explicit DualQuaternionT(const Matrix& _transformation);
// default quaternions
......
......@@ -100,11 +100,11 @@ public:
: Vec4(_w, _x, _y, _z) {}
/// construct from 3D point (pure imaginary quaternion)
QuaternionT(const Vec3& _p)
explicit QuaternionT(const Vec3& _p)
: Vec4(0, _p[0], _p[1], _p[2]) {}
/// construct from 4D vector
QuaternionT(const Vec4& _p)
explicit QuaternionT(const Vec4& _p)
: Vec4(_p[0], _p[1], _p[2], _p[3]) {}
/// construct from rotation axis and angle (in radians)
......@@ -121,7 +121,7 @@ public:
/// construct from rotation matrix (only valid for rotation matrices!)
template <class MatrixT>
QuaternionT(const MatrixT& _rot)
explicit QuaternionT(const MatrixT& _rot)
{ init_from_matrix( _rot); }
......
......@@ -120,7 +120,7 @@ public:
unsigned int slices, stacks;
// Constructor
Primitive(GlutPrimitiveType _t)
explicit Primitive(GlutPrimitiveType _t)
{
// Set the type
type = _t;
......
......@@ -531,7 +531,7 @@ class FindNodeAction
public:
/// constructor: _node_id is the node to be searched for
FindNodeAction(unsigned int _node_id) :
explicit FindNodeAction(unsigned int _node_id) :
node_id_(_node_id), node_ptr_(0) {}
bool operator()(BaseNode* _node)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment