Commit 47a19b2d authored by Jan Möbius's avatar Jan Möbius

Fiexed some cppcheck warnings

parent 01d53354
......@@ -59,7 +59,7 @@ echo "CPPCHECK Summary"
echo "=============================================================================="
echo -e "${NC}"
MAX_ERROR=105
MAX_ERROR=100
if [ $COUNT -gt $MAX_ERROR ]; then
echo -e ${WARNING}
......
......@@ -208,7 +208,7 @@ DrawMode::DrawMode() {
layers_[0] = DrawModeProperties();
}
DrawMode::DrawMode(ModeFlagSet _flags) :
DrawMode::DrawMode(const ModeFlagSet& _flags) :
modeFlags_(_flags)
{
layers_.resize(1);
......@@ -523,7 +523,7 @@ bool DrawMode::isAtomic() const {
//----------------------------------------------------------------------------
bool
DrawMode::containsAtomicDrawMode( DrawMode _atomicDrawMode) const
DrawMode::containsAtomicDrawMode( const DrawMode& _atomicDrawMode) const
{
return (*this) & _atomicDrawMode;
}
......
......@@ -316,7 +316,7 @@ namespace DrawModes {
*
* @param _flags Flags for the new drawmode defined by a bitset
*/
DrawMode( ModeFlagSet _flags );
DrawMode( const ModeFlagSet& _flags );
/* \brief Returns a registered draw mode based on the description passed or if none could be found the default one.
*
......@@ -440,7 +440,7 @@ namespace DrawModes {
/** \brief Check whether an Atomic DrawMode is active in this draw Mode
*/
bool containsAtomicDrawMode( DrawMode _atomicDrawMode ) const;
bool containsAtomicDrawMode( const DrawMode& _atomicDrawMode ) const;
/** \brief Separates this drawMode into a list of all separate atomic draw modes
*
......
......@@ -647,7 +647,7 @@ public:
* @param _mode The draw mode set for the traversed nodes
* @param _force If true, the mode is set ignoring if its supported by the nodes
*/
SetDrawModesAction(DrawModes::DrawMode _mode, bool _force = false ) : newModes_(_mode),force_(_force) {}
SetDrawModesAction(const DrawModes::DrawMode& _mode, bool _force = false ) : newModes_(_mode),force_(_force) {}
bool operator()(BaseNode* _node)
{
......@@ -695,7 +695,7 @@ class DrawAction
public:
/// Constructor: draws the scenegraph using _drawMode
DrawAction(DrawModes::DrawMode _drawMode, GLState& _state, bool _blending) :
DrawAction(const DrawModes::DrawMode& _drawMode, GLState& _state, bool _blending) :
state_(_state),
drawMode_(_drawMode),
blending_(_blending) {}
......@@ -754,7 +754,7 @@ class ACGDLLEXPORT PickAction
public:
/// constructor: what picking target to use
PickAction(GLState &_state, PickTarget _target, DrawModes::DrawMode _drawmode) :
PickAction(GLState &_state, PickTarget _target, const DrawModes::DrawMode& _drawmode) :
state_(_state),
pickTarget_(_target),
drawmode_(_drawmode) {}
......
......@@ -295,8 +295,8 @@ disableShader (DrawModes::DrawMode _drawmode) {
void
ShaderNode::
setShader( DrawModes::DrawMode _drawmode ,
std::string _vertexShader,
std::string _fragmentShader,
const std::string& _vertexShader,
const std::string& _fragmentShader,
std::string _pickVertexShader,
std::string _pickFragmentShader) {
......
......@@ -132,8 +132,8 @@ public:
*/
void setShader( DrawModes::DrawMode _drawmode ,
std::string _vertexShader,
std::string _fragmentShader,
const std::string& _vertexShader,
const std::string& _fragmentShader,
std::string _pickVertexShader = "",
std::string _pickFragmentShader = "");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment