Commit 211a7ac6 authored by Martin Schultz's avatar Martin Schultz
Browse files

fixed some cppCheck warnings in aCG, to make the tests pass again.

parent b7c3dbca
......@@ -78,7 +78,7 @@ template<class Mesh>
MeshNodeT<Mesh>::
MeshNodeT(Mesh& _mesh,
BaseNode* _parent,
std::string _name ):
const std::string& _name ):
MeshNodeBase(_parent, _name),
mesh_(_mesh),
drawMesh_(0),
......
......@@ -122,9 +122,9 @@ public:
*
* The constructor needs a mesh on which this node will work.
*/
MeshNodeT(Mesh& _mesh,
BaseNode* _parent=0,
std::string _name="<MeshNode>" );
MeshNodeT( Mesh& _mesh,
BaseNode* _parent=0,
const std::string& _name="<MeshNode>" );
/// Destructor
virtual ~MeshNodeT();
......
......@@ -89,7 +89,7 @@ public:
/// Default constructor.
OBJNode( BaseNode* _parent=0,
std::string _name="<OBJNode>" )
const std::string& _name="<OBJNode>" )
: BaseNode(_parent, _name)
{}
......
......@@ -100,7 +100,7 @@ public:
/// default constructor
PointNode( BaseNode* _parent=0,
std::string _name="<PointNode>" )
const std::string & _name="<PointNode>" )
: BaseNode(_parent, _name)
{}
......
......@@ -80,7 +80,7 @@ namespace SceneGraph {
/// Default constructor
PrincipalAxisNode::PrincipalAxisNode( BaseNode* _parent,
std::string _name)
const std::string& _name)
: BaseNode(_parent, _name),
auto_range_(false),
max_abs_value_(1.0),
......
......@@ -152,7 +152,7 @@ public:
/// Default constructor.
PrincipalAxisNode( BaseNode* _parent=0,
std::string _name="<PrincipalAxis>" );
const std::string& _name="<PrincipalAxis>" );
/// destructor
virtual ~PrincipalAxisNode();
......
......@@ -73,8 +73,8 @@ namespace SceneGraph {
//== IMPLEMENTATION ==========================================================
QuadNode::QuadNode( BaseNode* _parent,
std::string _name )
QuadNode::QuadNode( BaseNode* _parent,
const std::string& _name )
: BaseNode(_parent, _name)
{
}
......
......@@ -79,8 +79,8 @@ public:
typedef std::vector<ACG::Vec3f> PointVector;
QuadNode( BaseNode* _parent=0,
std::string _name="<QuadNode>" );
QuadNode( BaseNode* _parent=0,
const std::string& _name="<QuadNode>" );
virtual ~QuadNode();
ACG_CLASSNAME(QuadNode);
......
......@@ -63,7 +63,7 @@ namespace SceneGraph {
SliceNode::SliceNode( BaseNode * _parent,
std::string _name ) :
const std::string& _name ) :
BaseNode( _parent, _name ),
view_frame_(false),
enabled_(NONE)
......
......@@ -85,8 +85,8 @@ public:
XZ_PLANE = 4
};
SliceNode( BaseNode * _parent = 0,
std::string _name = "<SliceNode>" );
SliceNode( BaseNode * _parent = 0,
const std::string & _name = "<SliceNode>" );
virtual ~SliceNode();
......
......@@ -94,7 +94,7 @@ QColor TextNode::color_ = QColor(255, 0, 0);
TextNode::
TextNode( BaseNode* _parent,
std::string _name,
const std::string& _name,
TextMode _textMode,
bool _alwaysOnTop)
: BaseNode(_parent, _name),
......
......@@ -110,7 +110,7 @@ public:
* @param _alwaysOnTop Draw text on top of everything else?
*/
TextNode( BaseNode* _parent=0,
std::string _name="<TextNode>",
const std::string& _name="<TextNode>",
TextMode _textMode = SCREEN_ALIGNED,
bool _alwaysOnTop = false);
......
......@@ -73,7 +73,7 @@ namespace SceneGraph {
TriangleNode::TriangleNode( BaseNode* _parent,
std::string _name )
const std::string& _name )
: BaseNode(_parent, _name)
{
}
......
......@@ -81,7 +81,7 @@ public:
typedef std::vector<ACG::Vec3f> PointVector;
TriangleNode( BaseNode* _parent=0,
std::string _name="<TriangleNode>" );
const std::string& _name="<TriangleNode>" );
virtual ~TriangleNode();
ACG_CLASSNAME(TriangleNode);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment