OpenFlipper-Free issueshttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues2017-07-27T11:09:08Zhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/101Qt 5.8 moc generation problem2017-07-27T11:09:08ZMartin SchultzQt 5.8 moc generation problemin Qt 5.8.0 there is a bug considering the generation of moc files. the flags for cmake moc file generation are overridden when msvc is used:
https://bugreports.qt.io/browse/QTBUG-58345
in Qt 5.9.0 this bug is fixed.
if you comp...in Qt 5.8.0 there is a bug considering the generation of moc files. the flags for cmake moc file generation are overridden when msvc is used:
https://bugreports.qt.io/browse/QTBUG-58345
in Qt 5.9.0 this bug is fixed.
if you compare the file of qt 5.8.0 with the one of qt 5.9.0
http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/Qt5CoreMacros.cmake?h=5.9.0
you can see a very simple fix for this problem. However the online installer does not offer a patched version of qt 5.8 so you have to fix it yourself for now.
the fix for this was implemented in qt on
https://codereview.qt-project.org/#/c/184321
so you can compile qt yourself if you want to use 5.8. or try the 5.9 beta buildshttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/100move away from deprecated QTScript to QJSEngine based scripting2020-11-24T08:33:04ZJascha Wedowskimove away from deprecated QTScript to QJSEngine based scriptingQTScript is deprecated since QT 5.5 (?), recommended alternative is QJSEngine.
Problems with moving away are:
* QTScript systems are present in interfaces -> interfaces will have to change
* As a result of this, plugins using the script...QTScript is deprecated since QT 5.5 (?), recommended alternative is QJSEngine.
Problems with moving away are:
* QTScript systems are present in interfaces -> interfaces will have to change
* As a result of this, plugins using the scripting system have to be touched
First step: Abstract direct usage of QTScript classes in usage code (i.e. PropertyVisPlugin) to find suitable new abstraction
When this is done, make all usage code use new abstraction, then incrementally port internals to QJSEngine.Jascha WedowskiJascha Wedowskihttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/99Check VS2013 build error (OM Test fail?)2017-05-02T17:37:36ZJan Möbiusmoebius@cs.rwth-aachen.deCheck VS2013 build error (OM Test fail?)OpenFlipper-4.0Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/98~MeshObjectSelectionPlugin() crash2017-04-27T10:46:38ZMartin Heistermann~MeshObjectSelectionPlugin() crashThis script crashes on exit (run without -b):
```
core.loadObject("some.obj");
core.exitApplication();
```
I assume the object doesn't matter, attaching just in case.
Backtrace:
```
Trying a backtrace to show what happened last:
Stack ...This script crashes on exit (run without -b):
```
core.loadObject("some.obj");
core.exitApplication();
```
I assume the object doesn't matter, attaching just in case.
Backtrace:
```
Trying a backtrace to show what happened last:
Stack frames: 10
0: OpenFlipper :: backtrace() (+0x26) [0x558fe6cc53f6]
1: OpenFlipper :: segfaultHandling(int) (+0x16a) [0x558fe6cc5e8a]
2: /lib/x86_64-linux-gnu/libc.so.6 :: (+0x33040) [0x7f008d560040]
3: /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 :: QWidget::~QWidget() (+0x47f) [0x7f008f5e9cef]
4: /home/mxn/src/OpenFlipper-Free/build-reldebug/Build/lib/plugins/libPlugin-SelectionMeshObject.so :: MeshObjectSelectionPlugin::~MeshObjectSelectionPlugin() (+0x1fd) [0x7effa051572d]
5: /home/mxn/src/OpenFlipper-Free/build-reldebug/Build/lib/plugins/libPlugin-SelectionMeshObject.so :: MeshObjectSelectionPlugin::~MeshObjectSelectionPlugin() (+0x9) [0x7effa05159f9]
6: /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 :: (+0x273839) [0x7f008ecb8839]
7: /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 :: (+0x274fcf) [0x7f008ecb9fcf]
8: /lib/x86_64-linux-gnu/libc.so.6 :: __cxa_finalize (+0x8f) [0x7f008d562c8f]
9: /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 :: (+0x7ed43) [0x7f008eac3d43]
Backtrace completed, trying to abort now ...
Trying to get additional information (This might fail if the memory is corrupted).
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
[1] 5551 abort (core dumped) OpenFlipper -c crash.ofs
```
Not entirely sure what the problem is - especially as it does not occur when manually exiting OF instead of using core.exitApplication.Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/97SelectionBasePlugin::findObjectType dereferences a past-the-end iterator.2017-04-25T06:46:43ZMartin HeistermannSelectionBasePlugin::findObjectType dereferences a past-the-end iterator.if obj is non-null, but selectionEnvironments is empty_, it will deref the end iterator.
Found this using glibc's checked iterator option:
```
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/debug/safe_itera...if obj is non-null, but selectionEnvironments is empty_, it will deref the end iterator.
Found this using glibc's checked iterator option:
```
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/debug/safe_iterator.h:284:
Error: attempt to dereference a past-the-end iterator.
Objects involved in the operation:
iterator "this" @ 0x0x7fff72800988 {
type = __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<QString const, SelectionBasePlugin::SelectionEnvironment> >, std::__debug::map<QString, SelectionBasePlugin::SelectionEnvironment, std::less<QString>, std::allocator<std::pair<QString const, SelectionBasePlugin::SelectionEnvironment> > > > (mutable iterator);
state = past-the-end;
references sequence with type 'std::__debug::map<QString, SelectionBasePlugin::SelectionEnvironment, std::less<QString>, std::allocator<std::pair<QString const, SelectionBasePlugin::SelectionEnvironment> > >' @ 0x0x26f5cc8
}
Command terminated by signal 6
```
Backtrace:
```
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:58
#1 0x00007f43907aa40a in __GI_abort () at abort.c:89
#2 0x00007f43910e65eb in __gnu_debug::_Error_formatter::_M_error() const () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x00007f42ca963f83 in __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<QString const, SelectionBasePlugin::SelectionEnvironment> >, std::__debug::map<QString, SelectionBasePlugin::SelectionEnvironment, std::less<QString>, std::allocator<std::pair<QString const, SelectionBasePlugin::SelectionEnvironment> > > >::operator-> (
this=0x7fff72800988) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/debug/safe_iterator.h:282
#4 0x00007f42ca960062 in SelectionBasePlugin::findObjectType (this=<optimized out>, obj=<optimized out>, found=<optimized out>, env=<optimized out>, _id=<optimized out>)
at /home/gitlab-runner/src/OpenFlipper-Free/PluginCollection-Selection/Plugin-SelectionBase/SelectionBasePlugin.cc:1823
#5 0x00007f42ca95faa1 in SelectionBasePlugin::addedEmptyObject (this=0x26f5c50, _id=2)
at /home/gitlab-runner/src/OpenFlipper-Free/PluginCollection-Selection/Plugin-SelectionBase/SelectionBasePlugin.cc:1495
#6 0x00007f4391bac5e9 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7 0x000000000065add1 in Core::emptyObjectAdded (this=0x2, _t1=<optimized out>)
at /home/gitlab-runner/src/OpenFlipper-Free/build-RelWithDebInfo-clang4-asan/OpenFlipper/CoreApp/moc_Core.cpp:2996
#8 0x000000000055c540 in Core::slotEmptyObjectAdded (this=0x1d98380, _id=2) at /home/gitlab-runner/src/OpenFlipper-Free/OpenFlipper/Core/openFunctions.cc:771
#9 0x00007f4391bad499 in QObject::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
[...]
```Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/96Angle Based Edge Selection2017-04-20T10:23:35ZMartin SchultzAngle Based Edge Selection* is the angle given in Radians?
* add a tooltip for max Angle
* is this angle only for floodfill slection, or does it apply to other cases too?* is the angle given in Radians?
* add a tooltip for max Angle
* is this angle only for floodfill slection, or does it apply to other cases too?Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/95Windows does not execute plugin unittests2017-04-20T10:23:35ZJan Möbiusmoebius@cs.rwth-aachen.deWindows does not execute plugin unittestsOpenFlipper-4.0Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/94OpenFlipper debug build does not run with gdb2017-05-08T15:04:45ZChristopher TenterOpenFlipper debug build does not run with gdbgdb reports an internal error when OpenFlipper loads the plugins and then terminates.
This happens with the current master branch.
gdb reports an internal error when OpenFlipper loads the plugins and then terminates.
This happens with the current master branch.
https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/93Investigae CMAKE performance2017-05-23T13:15:04ZMartin SchultzInvestigae CMAKE performanceCMAKE has become quite slow. investigate possible performance issues by means of profiling and analysis of the cmake code.CMAKE has become quite slow. investigate possible performance issues by means of profiling and analysis of the cmake code.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/92Write unittest for Merge plugin2020-04-23T09:47:48ZMartin SchultzWrite unittest for Merge pluginit seems like the merge plugin is not copying the properties in the merge process as intended.
Investigate and fix this, s.t. at least standard properties are copied.
In addition to that write a unittest to check if properties are copied...it seems like the merge plugin is not copying the properties in the merge process as intended.
Investigate and fix this, s.t. at least standard properties are copied.
In addition to that write a unittest to check if properties are copied as intended.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/91Deselection of Global Draw Mode when shift-clicking other Draw Mode2017-05-04T14:40:30ZPeter CollienneDeselection of Global Draw Mode when shift-clicking other Draw ModeExample:
The global Draw Mode is set to "solid (colored per face)". Whenever i shift-click on wireframe to also see the wireframe, the global draw mode is deselected and all i see is a wireframe.
Desired Behaviour: Keep the previous glob...Example:
The global Draw Mode is set to "solid (colored per face)". Whenever i shift-click on wireframe to also see the wireframe, the global draw mode is deselected and all i see is a wireframe.
Desired Behaviour: Keep the previous global draw mode and additionaly render using the selected draw mode when shift-clicking a different draw modeOpenFlipper-4.0Jascha WedowskiJascha Wedowskihttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/90Updates to OpenVolumemesh cause problems in OpenFlippe2017-05-04T12:33:24ZJan Möbiusmoebius@cs.rwth-aachen.deUpdates to OpenVolumemesh cause problems in OpenFlippeBranch is Update_OVMBranch is Update_OVMOpenFlipper-4.0Max Lyonlyon@cs.rwth-aachen.deMax Lyonlyon@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/89meshConversion fails when converting to polyMesh2017-05-04T12:33:24ZMartin SchultzmeshConversion fails when converting to polyMeshthe scripted code returns always -1 when a mesh is converted to polymesh.
seems to be a type of line 139 where a local copy of the variable newID is used.the scripted code returns always -1 when a mesh is converted to polymesh.
seems to be a type of line 139 where a local copy of the variable newID is used.Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/88OpenFlipper needs resize to work2017-05-04T12:33:24ZMartin SchultzOpenFlipper needs resize to workWhen i start openflipper, the opengl canvas remains black no matter what i do.
Only after i resized the window, the opengl canvas gets updated and from then on works as expected.
I don't think the application should behave this way a...When i start openflipper, the opengl canvas remains black no matter what i do.
Only after i resized the window, the opengl canvas gets updated and from then on works as expected.
I don't think the application should behave this way after startup.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/87Plugin MeshConvert cppcheck2017-05-04T12:33:24ZJan Möbiusmoebius@cs.rwth-aachen.dePlugin MeshConvert cppcheckPlugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::toolbar' is not initialized in the constructor.
[Plugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::grp' is not init...Plugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::toolbar' is not initialized in the constructor.
[Plugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::grp' is not initialized in the constructor.
[Plugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::bidirectionalConversion' is not initialized in the constructor.
[Plugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::polyConversion' is not initialized in the constructor.
[Plugin-MeshConvert/MeshConvert.cc:104]: (warning) Member variable 'MeshConvertPlugin::triConversion' is not initialized in the constructor.OpenFlipper-4.0Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/86Sort out the defines in the OpenVolumemesh plugins2017-05-04T12:33:24ZJan Möbiusmoebius@cs.rwth-aachen.deSort out the defines in the OpenVolumemesh pluginsThe types define ENABLE_POLYHEDRALMESH_SUPPORT
while the plugins curreently seem to use -DENABLE_OPENVOLUMEMESH_SUPPORT -DENABLE_OPENVOLUMEMESH_POLYHEDRAL_SUPPORTThe types define ENABLE_POLYHEDRALMESH_SUPPORT
while the plugins curreently seem to use -DENABLE_OPENVOLUMEMESH_SUPPORT -DENABLE_OPENVOLUMEMESH_POLYHEDRAL_SUPPORTOpenFlipper-4.0Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/85Removed workaround2017-05-04T12:33:24ZJan Möbiusmoebius@cs.rwth-aachen.deRemoved workaroundThe workaround for qt creator has been removed and replaced by a cmake internal command.
Please check if it works.The workaround for qt creator has been removed and replaced by a cmake internal command.
Please check if it works.OpenFlipper-4.0Martin HeistermannMartin Heistermannhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/84BSPImplT (OMTriangleBSP) fails on small meshes.2017-05-04T12:33:24ZHans-Christian EbkeBSPImplT (OMTriangleBSP) fails on small meshes.The BSPImplT, the foundation for anything space partitioning related, all ray intersection stuff, all projection stuff, etc. fails on really small meshes. It doesn't find any ray collisions.The BSPImplT, the foundation for anything space partitioning related, all ray intersection stuff, all projection stuff, etc. fails on really small meshes. It doesn't find any ray collisions.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/83Visualization mode "Solid (face textured)" not available after loading obj w...2017-05-04T12:33:24ZMax Lyonlyon@cs.rwth-aachen.deVisualization mode "Solid (face textured)" not available after loading obj with halfedge texcoords.When loading the attached [box.obj](/uploads/989ca6d0927e700ba6850ee76985314f/box.obj) the halfedge_texcoord2D property is correctly filled with the data from the file. However, when choosing a visualization mode for the mesh, only "Soli...When loading the attached [box.obj](/uploads/989ca6d0927e700ba6850ee76985314f/box.obj) the halfedge_texcoord2D property is correctly filled with the data from the file. However, when choosing a visualization mode for the mesh, only "Solid (textured)" (using vertex texcoords) is available, "Solid (face textured)" (using halfedge texcoords) is not.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/82Draw mode "Solid (colored per vertex, shaded)" actually shows colors per face2017-05-04T12:33:24ZPatrick SchmidtDraw mode "Solid (colored per vertex, shaded)" actually shows colors per faceAfter assigning a color to each vertex and switching to the draw mode "Solid (colored per vertex, shaded)", I see the following:
![per_vertex_shaded](/uploads/04b7915038f5bad44bad7a8e8a3ad37c/per_vertex_shaded.png)
Instead of linearl...After assigning a color to each vertex and switching to the draw mode "Solid (colored per vertex, shaded)", I see the following:
![per_vertex_shaded](/uploads/04b7915038f5bad44bad7a8e8a3ad37c/per_vertex_shaded.png)
Instead of linearly interpolating the vertex colors, constant colors are shown per face.
The non-shaded draw mode "Solid (colored per vertex)" works just fine:
(Exact same colors are used)
![per_vertex](/uploads/48b445750eb49a2a1e2067e244eb862b/per_vertex.png)
In both cases, the shader pipeline renderer was used.