Revert "Merge branch 'featureQt5.6Support' into 'master'"

This reverts merge request !92

ACG/CMakeLists.txt

@@ -27,17 +27,12 @@ endif ()
 
 acg_openmp ()
 
-# check for OpenGL, GLEW and GLUT as our required dependencies
+# check for OpenGL and GLUT as our required dependencies
 find_package (OpenGL)
 if (NOT OPENGL_FOUND)
   message (FATAL_ERROR "OpengGL not found!")
 endif ()
 
-find_package (GLEW)
-if (NOT GLEW_FOUND)
-  message (FATAL_ERROR "GLEW not found!")
-endif ()
-
 find_package (GLUT)
 if (NOT GLUT_FOUND)
   message (FATAL_ERROR "GLUT not found!")
@@ -53,7 +48,6 @@ set(INCLUDE_DIRS ${OPENMESH_INCLUDE_DIRS}
                  ${CMAKE_CURRENT_SOURCE_DIR}/ShaderUtils
                  ${CMAKE_CURRENT_BINARY_DIR}
                  ${OPENGL_INCLUDE_DIR}
-                 ${GLEW_INCLUDE_DIR}
                  ${GLUT_INCLUDE_DIR} )
 
 set(ADDITIONAL_LINK_LIBRARIES "" )
@@ -90,7 +84,6 @@ include_directories (
 )
 
 link_directories (
-  ${GLEW_LIBRARY_DIR}
   ${GLUT_LIBRARY_DIR}
 )
 
@@ -159,7 +152,6 @@ acg_print_configure_header (ACG "ACG")
 target_link_libraries ( ACG  ${OPENMESH_LIBRARIES}
                              ${QT_LIBRARIES}
                              ${OPENGL_LIBRARIES}
-                             ${GLEW_LIBRARY}
                              ${GLUT_LIBRARIES}
                              ${ADDITIONAL_LINK_LIBRARIES} )
 

ACG/GL/AntiAliasing.cc

@@ -126,10 +126,13 @@ MSFilterWeights::MSFilterWeights(int _numSamples) : numSamples_(_numSamples) {
 
 //=============================================================================
 
+#if defined(GL_ARB_texture_buffer_object)
+    
 void MSFilterWeights::asTextureBuffer( TextureBuffer& out ) {
   if (numSamples_)
     out.setBufferData(numSamples_ * 4, &weights_[0], GL_R32F, GL_STATIC_DRAW);
 }
+#endif
 
 //=============================================================================
 

ACG/GL/FBO.cc

@@ -125,7 +125,6 @@ void FBO::del()
 
 void FBO::attachTexture( GLenum _attachment, GLuint _texture, GLuint _level )
 {
-#ifdef GL_VERSION_3_2
   // bind fbo
   bind();
 
@@ -155,9 +154,6 @@ void FBO::attachTexture( GLenum _attachment, GLuint _texture, GLuint _level )
 
   // track texture id
   attachments_[_attachment] = intID;
-#else
-  std::cerr << "error: FBO::attachTexture unsupported - update glew headers and rebuild" << std::endl;
-#endif
 }
 
 //-----------------------------------------------------------------------------

ACG/GL/GLFormatInfo.cc

@@ -47,6 +47,7 @@
  *                                                                            *
  \*===========================================================================*/
 
+#include <ACG/GL/acg_glew.hh>
 #include <ACG/GL/GLFormatInfo.hh>
 #include <iostream>
 #include <QString>
@@ -81,7 +82,6 @@ GLFormatInfo::GLFormatInfo( GLenum _internalFormat )
     registerFmt(GL_DEPTH_STENCIL, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8, 24, 8, 0, 0, UnsignedInt, false);
     registerFmt(GL_DEPTH24_STENCIL8, GL_DEPTH_STENCIL, GL_UNSIGNED_INT_24_8, 24, 8, 0, 0, UnsignedInt, false);
 
-#ifdef GL_VERSION_3_0
     // single channel formats
     registerFmt(GL_R8, GL_RED, GL_UNSIGNED_BYTE, 8, 0, 0, 0, UnsignedInt, true);
     registerFmt(GL_R8_SNORM, GL_RED, GL_BYTE, 8, 0, 0, 0, SignedInt, true);
@@ -130,19 +130,18 @@ GLFormatInfo::GLFormatInfo( GLenum _internalFormat )
     registerFmt(GL_RGBA32I, GL_RGBA_INTEGER, GL_INT, 32, 32, 32, 32, SignedInt, false);
     registerFmt(GL_RGBA32UI, GL_RGBA_INTEGER, GL_UNSIGNED_INT, 32, 32, 32, 32, UnsignedInt, false);
     registerFmt(GL_RGBA32F, GL_RGBA, GL_FLOAT, 32, 32, 32, 32, FloatingPt, false);
-#endif // GL_VERSION_3_0
 
     // depth
     registerFmt(GL_DEPTH_COMPONENT24, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT, 24, 0, 0, 0, UnsignedInt, false);
     registerFmt(GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT, 16, 0, 0, 0, UnsignedInt, false);
-#ifdef GL_ARB_depth_buffer_float
+#ifdef GL_DEPTH_COMPONENT32F
     registerFmt(GL_DEPTH_COMPONENT32F, GL_DEPTH_COMPONENT, GL_FLOAT, 32, 0, 0, 0, FloatingPt, false);
     registerFmt(GL_DEPTH32F_STENCIL8, GL_DEPTH_STENCIL, GL_FLOAT_32_UNSIGNED_INT_24_8_REV, 32, 8, -24, 0, FloatingPt, false);
-#endif // GL_ARB_depth_buffer_float
+#endif
 
-#ifdef GL_ARB_texture_stencil8
+#ifdef GL_STENCIL_INDEX8
     registerFmt(GL_STENCIL_INDEX8, GL_STENCIL_INDEX, GL_UNSIGNED_BYTE, 8, 0, 0, 0,  UnsignedInt, false);
-#endif // GL_ARB_texture_stencil8
+#endif
   }
 
   std::map<GLenum, GLFormatInfo>::iterator f = formatMap_.find(_internalFormat);

ACG/GL/GLState.cc

@@ -1327,7 +1327,7 @@ void GLState::syncFromGL()
   
   GLint getparam;
 
-#ifdef GL_VERSION_1_4
+#ifdef GL_BLEND_SRC_RGB
   glGetIntegerv(GL_BLEND_SRC_RGB, &getparam);
   stateStack_.back().blendFuncState_[0] = getparam;
 
@@ -1611,7 +1611,7 @@ void GLState::blendFuncSeparate(GLenum _srcRGB, GLenum _dstRGB, GLenum _srcAlpha
       stateStack_.back().blendFuncState_[2] != _srcAlpha || stateStack_.back().blendFuncState_[3] != _dstAlpha)
 #endif
     {
-#ifdef GL_VERSION_1_4
+#ifdef GL_BLEND_SRC_RGB
       // check if glew has loaded glBlendFuncSeparate already
       if (glBlendFuncSeparate)
         glBlendFuncSeparate(_srcRGB, _dstRGB, _srcAlpha, _dstAlpha);

ACG/GL/IRenderer.cc

@@ -316,7 +316,7 @@ void IRenderer::addRenderObject(ACG::RenderObject* _renderObject)
     p->internalFlags_ = 0;
 
     // precompile shader
-#ifdef GL_VERSION_3_2
+#ifdef GL_GEOMETRY_INPUT_TYPE
     GLSL::Program* shaderProg = ACG::ShaderCache::getInstance()->getProgram(&p->shaderDesc);
 #endif
 
@@ -324,7 +324,7 @@ void IRenderer::addRenderObject(ACG::RenderObject* _renderObject)
     // check primitive type and geometry shader
     if (errorDetectionLevel_ > 1 && p->shaderDesc.geometryTemplateFile.length())
     {
-#ifdef GL_VERSION_3_2
+#ifdef GL_GEOMETRY_INPUT_TYPE
       GLint geomInputType = 0;
       glGetProgramiv(shaderProg->getProgramId(), GL_GEOMETRY_INPUT_TYPE, &geomInputType);
 

ACG/GL/ScreenQuad.cc

@@ -188,14 +188,7 @@ void ScreenQuad::intDraw (GLSL::Program* _prog, int _numInstances)
   if (_numInstances < 1)
     glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
   else
-  {
-#ifdef GL_VERSION_3_1
     glDrawArraysInstanced(GL_TRIANGLE_STRIP, 0, 4, _numInstances);
-#else
-    std::cerr << "error: instanced ScreenQuad draw - outdated glew version" << std::endl;
-    glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
-#endif
-  }
 
   if (_prog)
     decl_->deactivateShaderPipeline(_prog);

ACG/GL/acg_glew.hh

@@ -62,20 +62,13 @@
 #include <cstdlib>
 #include <sstream>
 
+#ifndef __APPLE__
+    #include "gl_compat_4_4.hh"
+#else
+    #include <qgl>
+#endif
 
-#if defined(ARCH_DARWIN)
-
-  #include <gl/glew.h>
-
-#elif defined(WIN32)
-
-  #include <gl/glew.h>
-
-#else // Unix
-
-    #include <GL/glew.h>
 
-#endif
 
 
 //=============================================================================

ACG/GL/gl.hh

@@ -69,11 +69,8 @@
 
 #elif defined(WIN32)
 
+  #include "acg_glew.hh"
   #include <windows.h>
-  // Dont do this anymore! Use dll version. No problems with plugins and dll
-  // but a lot with static linking
-  // #  define GLEW_STATIC 1
-  #include <gl/glew.h>
   #include <gl/glut.h>
 
 #else

ACG/GL/globjects.cc

@@ -47,6 +47,7 @@
  *                                                                            *
  \*===========================================================================*/
 
+
 #include <ACG/GL/acg_glew.hh>
 #include <ACG/GL/globjects.hh>
 #include <ACG/GL/GLFormatInfo.hh>

ACG/QtWidgets/QtBaseViewer.cc

@@ -1128,7 +1128,8 @@ void QtBaseViewer::initializeGL()
   // we use GLEW to manage extensions
   // initialize it first
   #ifndef __APPLE__
-  glewInit();
+  //glewInit();
+  ogl_LoadFunctions();
   #endif
 
 
@@ -1242,7 +1243,8 @@ void QtBaseViewer::paintGL()
     // we use GLEW to manage extensions
     // initialize it first
     #ifndef __APPLE__
-    glewInit();
+    //glewInit();
+    ogl_LoadFunctions();
     #endif
 
     // lock update

CMakeLists.txt

@@ -131,17 +131,12 @@ endif()
 
 acg_openmp ()
 
-# check for OpenGL, GLEW and GLUT as our required dependencies
+# check for OpenGL and GLUT as our required dependencies
 find_package (OpenGL)
 if (NOT OPENGL_FOUND)
   message (FATAL_ERROR "OpengGL not found!")
 endif ()
 
-find_package (GLEW)
-if (NOT GLEW_FOUND)
-  message (FATAL_ERROR "GLEW not found!")
-endif ()
-
 find_package (GLUT)
 if (NOT GLUT_FOUND)
   message (FATAL_ERROR "GLUT not found!")

OpenFlipper/Core/Core.cc

@@ -2035,7 +2035,7 @@ void Core::showReducedMenuBar(bool reduced) {
 }
 
 void Core::finishSplash() {
-    splash_->finish(coreWidget_);
+    splash_->finish(coreWidget_);	
 }
 
 

OpenFlipper/CoreApp/CMakeLists.txt

@@ -7,7 +7,6 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
   ${CMAKE_CURRENT_BINARY_DIR}
   ${OPENGL_INCLUDE_DIR}
-  ${GLEW_INCLUDE_DIR}
   ${GLUT_INCLUDE_DIR}
 )
 
@@ -29,14 +28,8 @@ if( APPLE )
   endforeach ()
 
   link_directories (
-    ${GLEW_LIBRARY_DIR}
     ${ADDITIONAL_PLUGINLIB_LINK_DIRS}
   )
-
-else (APPLE)
-   link_directories (
-      ${GLEW_LIBRARY_DIR}
-   )
 endif(APPLE)
 
 if (WIN32)
@@ -229,7 +222,6 @@ target_link_libraries (${OPENFLIPPER_PRODUCT_STRING}
   OpenFlipperPluginLib
   ${QT_LIBRARIES}
   ${OPENGL_LIBRARIES}
-  ${GLEW_LIBRARY}
   ${GLUT_LIBRARIES}
   ${COREAPP_ADDITIONAL_LINK_LIBRARIES}
   ${OPENFLIPPER_STATIC_PLUGINS}

OpenFlipper/Documentation/DeveloperHelpSources/building.docu

@@ -11,7 +11,6 @@ OpenFlipper.
 <ul>
 <li> 5.5 >= Qt >= 4.8.6  ( http://www.qt.io/download/ ) Use the OpenGL version for Qt >= 5.0</li>
 <li> GLUT         ( http://www.opengl.org/resources/libraries/glut/ )</li>
-<li> GLEW (>=1.6) ( http://glew.sourceforge.net )</li>
 </ul>
 
 \section optlibs Optional libraries ( Without these libraries some functionality might not be available) 

OpenFlipper/OpenFlipper.cc

@@ -446,13 +446,9 @@ int main(int argc, char **argv)
         }
       }
      }
-    
-    // After setting all Options from command line, build the real gui
-    w->init();
 
-    #ifndef __APPLE__
-    initGlew();
-    #endif
+    // After setting all Options from command line, build the real gui
+    w->init();   
  
     for ( int i = 0 ; i < args.FileCount(); ++i )
       w->commandLineOpen(args.File(i), openPolyMeshes);    

OpenFlipper/PluginLib/CMakeLists.txt

@@ -42,14 +42,12 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
   ${CMAKE_CURRENT_BINARY_DIR}
   ${OPENGL_INCLUDE_DIR}
-  ${GLEW_INCLUDE_DIR}
   ${GLUT_INCLUDE_DIR}
   ${ADDITIONAL_PLUGINLIB_INCS}
   ${PACKAGE_INCLUDES}
 )
 
 link_directories (
-  ${GLEW_LIBRARY_DIR}
   ${ADDITIONAL_PLUGINLIB_LINK_DIRS}
 )
 
@@ -176,7 +174,6 @@ target_link_libraries (OpenFlipperPluginLib
   ACG
   ${QT_LIBRARIES}
   ${OPENGL_LIBRARIES}
-  ${GLEW_LIBRARY}
   ${GLUT_LIBRARIES}
   ${FTGL_LIBS}
   ${ADDITIONAL_PLUGINLIB_LIBS}

OpenFlipper/cmake/plugin.cmake

@@ -16,7 +16,6 @@
 #                      [TRANSLATION_ADDFILES file1 file2 ...]
 #                      [LICENSEMANAGER])
 #
-
 # DIRS                   = additional directories with source files
 # DEPS                   = required dependencies for find_package macro
 # OPTDEPS                = optional dependencies for find_package macro, if found, a define ENABLE_<Depname> will be added automatically
@@ -29,7 +28,6 @@
 # INCDIRS                = additional include directories
 # ADDSRC                 = additional source files
 # INSTALLDATA            = directories that will be installed into the openflipper data directory
-# GLEWDEFINITIONS = Checks glew if it defines the given definitions
 #
 # TRANSLATION_LANGUAGES = language codes for translation
 # TRANSLATION_ADDFILES  = additional files that should be included into the translation files
@@ -72,7 +70,7 @@ endmacro ()
 macro (_get_plugin_parameters _prefix)
     set (_current_var _foo)
     set (_supported_var DIRS DEPS OPTDEPS LDFLAGSADD CFLAGSADD CDEFINITIONSADD
-      LIBRARIES ADD_CORE_APP_LIBRARIES LIBDIRS INCDIRS ADDSRC INSTALLDATA GLEWDEFINITIONS TRANSLATION_LANGUAGES TRANSLATION_ADDFILES)
+      LIBRARIES ADD_CORE_APP_LIBRARIES LIBDIRS INCDIRS ADDSRC INSTALLDATA TRANSLATION_LANGUAGES TRANSLATION_ADDFILES)
     set (_supported_flags LICENSEMANAGER)
     foreach (_val ${_supported_var})
         set (${_prefix}_${_val})
@@ -376,26 +374,6 @@ macro (_plugin_licensemanagement)
   endif()
 endmacro ()
 
-#======================================================
-# check dependencies in GLEW library
-# _prefix    : prefix used ( usually the plugin name )
-#======================================================
-macro (_check_plugin_glew_deps _prefix )
-
- foreach (_extension ${${_prefix}_GLEWDEFINITIONS})
-
-   acg_test_glew_definition( ${_extension} ${_prefix}_GLEW_HAS_DEFINITION_${_extension}  )
-
-   # If the dependency is not found, we disable the plugin
-   if(NOT ${_prefix}_GLEW_HAS_DEFINITION_${_extension} )
-      set (${_prefix}_HAS_DEPS FALSE)
-      acg_set (_${_prefix}_MISSING_DEPS "${_${_prefix}_MISSING_DEPS} GLEW extension ${_extension}")
-   endif()
-
- endforeach()
-
-endmacro ()
-
 
 
 #======================================================
@@ -438,10 +416,6 @@ function (_build_openflipper_plugin plugin)
   endforeach ()
   set_property( GLOBAL PROPERTY GLOBAL_CORE_APP_LIBRARIES ${global_core_app_libraries} )
 
-  # CHECK for GLEW definitions
-  #============================================================================================
-
-  _check_plugin_glew_deps (${_PLUGIN})
 
   #============================================================================================
   # Remember Lib dirs for bundle generation
@@ -486,7 +460,6 @@ function (_build_openflipper_plugin plugin)
       ${${_PLUGIN}_DEPS_INCDIRS}
       ${${_PLUGIN}_INCDIRS}
       ${OPENGL_INCLUDE_DIR}
-      ${GLEW_INCLUDE_DIR}
       ${GLUT_INCLUDE_DIR}
       ${CMAKE_BINARY_DIR}/OpenFlipper/PluginLib
       ${PACKAGE_INCLUDES}

OpenFlipper/common/glew_wrappers.cc

@@ -48,19 +48,26 @@
 \*===========================================================================*/
 
 #include "glew_wrappers.hh"
+#include <ACG/GL/gl_compat_4_4.hh>
 
-#include <GL/glew.h>
 #include <stdio.h>
+#include <string>
+#include <sstream>
 
-DLLEXPORT void initGlew() {
-    GLenum err = glewInit();
-    if (GLEW_OK != err)
+DLLEXPORT void initOpenGLFunctions() {
+  int error = ogl_LoadFunctions();
+    if(error != ogl_LOAD_SUCCEEDED)
     {
-      /* Problem: glewInit failed, something is seriously wrong. */
-      fprintf(stderr, "Error: %s\n", glewGetErrorString(err));
+      /* Problem: loading the opengl functions failed, something is seriously wrong. */
+      fprintf(stderr, "Error when initializing opengl functions: %d\n",error);
     }
 }
 
-DLLEXPORT const char * getGlewVersion() {
-    return (const char *)glewGetString(GLEW_VERSION);
+DLLEXPORT const char * getOpenGLVersion() {
+    std::string version;    
+    std::stringstream s;
+
+    s << ogl_GetMajorVersion() << "."<<ogl_GetMinorVersion();
+    version = s.str();
+    return version.c_str() ;
 }

OpenFlipper/common/glew_wrappers.hh

@@ -52,7 +52,7 @@
 
 #include <OpenFlipper/common/GlobalDefines.hh>
 
-DLLEXPORT void initGlew();
-DLLEXPORT const char * getGlewVersion();
+DLLEXPORT void initOpenGLFunctions();
+DLLEXPORT const char * getOpenGLVersion();
 
 #endif /* GLEW_WRAPPERS_HH_ */

OpenFlipper/widgets/coreWidget/About.cc

@@ -60,6 +60,7 @@
 //== INCLUDES =================================================================
 
 #include <common/glew_wrappers.hh>
+
 #include "CoreWidget.hh"
 #include <OpenFlipper/common/FileTypes.hh>
 
@@ -592,11 +593,12 @@ void CoreWidget::showAboutWidget( ) {
   #ifndef __APPLE__
   aboutWidget_->OpenFlipperAbout->append("\n");
   aboutWidget_->OpenFlipperAbout->setCurrentFont(boldFont);
-  aboutWidget_->OpenFlipperAbout->append(tr("GLEW Specific Info:"));
+  aboutWidget_->OpenFlipperAbout->append(tr("OpenGL Specific Info:"));
   aboutWidget_->OpenFlipperAbout->setCurrentFont(standardFont);
   
-  QString glewVersion = QString(getGlewVersion());
-  aboutWidget_->OpenFlipperAbout->append(tr("GLEW Version:\t") + glewVersion);
+  //TODO: rename this we are not using glew anymore
+  QString glewVersion = QString(getOpenGLVersion());
+  aboutWidget_->OpenFlipperAbout->append(tr("OpenGL Version:\t") + glewVersion);
   #endif
   
   // =====================================================================================

OpenFlipper/widgets/coreWidget/CoreWidget.cc

@@ -72,6 +72,7 @@
 
 // -------------------- Qt event Includes
 #include <QGLFormat>
+#include "common/glew_wrappers.hh"
 
 #define WIDGET_HEIGHT 800
 #define WIDGET_WIDTH  800
@@ -249,6 +250,7 @@ CoreWidget( QVector<ViewMode*>& _viewModes,
 #endif
 
   glWidget_ = new QGLWidget(format,0);
+  glWidget_->makeCurrent();
   PluginFunctions::shareGLWidget (glWidget_);
 
   glView_ = new QtGLGraphicsView(stackedWidget_);
@@ -317,6 +319,8 @@ CoreWidget( QVector<ViewMode*>& _viewModes,
   // Create examiner
   // ======================================================================
 
+  initOpenGLFunctions();
+
   // First we analyze the scenegraph
   unsigned int maxPases = 1;
   ACG::Vec3d bbmin,bbmax;

OpenFlipper/widgets/coreWidget/CoreWidget.hh

@@ -67,6 +67,7 @@
 
 #include <set>
 
+
 #include "OpenFlipper/common/Types.hh"
 #include <OpenFlipper/common/GlobalOptions.hh>
 #include <OpenFlipper/BasePlugin/ContextMenuInterface.hh>

OpenFlipper/widgets/glWidget/QtGLGraphicsScene.cc

@@ -110,9 +110,11 @@ void QtGLGraphicsScene::drawBackground(QPainter *_painter, const QRectF &_rect)
   static bool initialized = false;
   if (!initialized)
   {
-    // we use GLEW to manage extensions
+    // we use glLoadGen to manage extensions :/
     // initialize it first
-    glewInit();
+    #ifndef __APPLE__
+        ogl_LoadFunctions();    //maybe replace this with a call to the wrapper function. initOpenGLFunctions()
+    #endif
     for (unsigned int i = 0; i < views_->size (); i++)
     {
       views_->at(i)->initializeGL ();

OpenFlipper/widgets/glWidget/simpleGLGraphicsScene.cc

@@ -114,10 +114,10 @@ void SimpleGLGraphicsScene::drawBackground(QPainter *_painter, const QRectF &_re
 
   if (!initialized_)
   {
-    // we use GLEW to manage extensions
+    // we use glLoadGen to manage extensions
     // initialize it first
     #ifndef __APPLE__
-    glewInit();
+    ogl_LoadFunctions();
     #endif
     view_->initializeGL();
     cursorPainter_->initializeGL ();

PluginCollection-Renderers/Plugin-Render-Old-DepthPeeling/ClassicDepthPeeling_glew.cc

@@ -54,6 +54,10 @@
 #include <OpenFlipper/common/GlobalOptions.hh>
 #include <OpenFlipper/BasePlugin/PluginFunctions.hh>
 
+#ifndef GL_TEXTURE_RECTANGLE_EXT
+#define GL_TEXTURE_RECTANGLE_EXT 0x84F5
+#endif
+
 void DepthPeelingPlugin::reloadResources(int _viewerId) {
   // called in constructor and resizeEvent()
 

cmake/ACGCommon.cmake

@@ -260,84 +260,55 @@ macro (acg_qt5)
   
     
     find_package (Qt5Core QUIET)
-    if(Qt5Core_FOUND)
-        string(REGEX REPLACE "^([0-9]+)\\.[0-9]+\\.[0-9]+.*" "\\1" QT_VERSION_MAJOR "${Qt5Core_VERSION_STRING}")
-        string(REGEX REPLACE "^[0-9]+\\.([0-9])+\\.[0-9]+.*" "\\1" QT_VERSION_MINOR "${Qt5Core_VERSION_STRING}")
-        string(REGEX REPLACE "^[0-9]+\\.[0-9]+\\.([0-9]+).*" "\\1" QT_VERSION_PATCH "${Qt5Core_VERSION_STRING}")
-
-      #find WINDOWS_SDK to avoid qt error. This must be done BEFORE Qt5Widgets is searched
-      if (WIN32)
-        if ( (QT_VERSION_MAJOR EQUAL 5) AND (QT_VERSION_MINOR LESS 3 OR ( QT_VERSION_MINOR EQUAL 3 AND QT_VERSION_PATCH EQUAL 0 )) ) # for all Qt version > 5.0.0 and < 5.3.1
-          #glu32.lib is needed by qt5 opengl version. it cannot find it by itself so we help qt
-          #this block has to be executed, before Qt5Gui is searched, otherwise we will end up with the (not so useful) QT5 error message
-          set(WINDOWS_SDK_LIBS "COULD_NOT_FOUND" CACHE PATH "Path to the latest windows sdk libs which includes glu32.lib. Used by Qt5.")
-          if (EXISTS "${WINDOWS_SDK_LIBS}\\glu32.lib")
-            set (CMAKE_PREFIX_PATH "${CMAKE_PREFIX_PATH};${WINDOWS_SDK_LIBS}")
-          elseif(QT5_INSTALL_PATH_EXISTS) #trying to install qt5. notify about missing sdk before the qt message comes
-            message(FATAL_ERROR "Could not find glu32.lib. This is necessary for QT5 OpenGL version for windows, spleace specify glu32.lib in WINDOWS_SDK_LIB or install Qt version >= 5.3.1")
-          endif()
+     
+    #find WINDOWS_SDK to avoid qt error. This must be done BEFORE Qt5Widgets is searched
+    if (Qt5Core_FOUND AND WIN32)    
+      string(REGEX REPLACE "^([0-9]+)\\.[0-9]+\\.[0-9]+.*" "\\1" QT_VERSION_MAJOR "${Qt5Core_VERSION_STRING}")
+      string(REGEX REPLACE "^[0-9]+\\.([0-9])+\\.[0-9]+.*" "\\1" QT_VERSION_MINOR "${Qt5Core_VERSION_STRING}")
+      string(REGEX REPLACE "^[0-9]+\\.[0-9]+\\.([0-9]+).*" "\\1" QT_VERSION_PATCH "${Qt5Core_VERSION_STRING}")
+    
+      if ( (QT_VERSION_MAJOR EQUAL 5) AND (QT_VERSION_MINOR LESS 3 OR ( QT_VERSION_MINOR EQUAL 3 AND QT_VERSION_PATCH EQUAL 0 )) ) # for all Qt version > 5.0.0 and < 5.3.1
+        #glu32.lib is needed by qt5 opengl version. it cannot find it by itself so we help qt
+        #this block has to be executed, before Qt5Gui is searched, otherwise we will end up with the (not so useful) QT5 error message 
+        set(WINDOWS_SDK_LIBS "COULD_NOT_FOUND" CACHE PATH "Path to the latest windows sdk libs which includes glu32.lib. Used by Qt5.")
+        if (EXISTS "${WINDOWS_SDK_LIBS}\\glu32.lib")
+          set (CMAKE_PREFIX_PATH "${CMAKE_PREFIX_PATH};${WINDOWS_SDK_LIBS}")
+        elseif(QT5_INSTALL_PATH_EXISTS) #trying to install qt5. notify about missing sdk before the qt message comes
+          message(FATAL_ERROR "Could not find glu32.lib. This is necessary for QT5 OpenGL version for windows, spleace specify glu32.lib in WINDOWS_SDK_LIB or install Qt version >= 5.3.1")
         endif()
-      endif(WIN32)
-
-      #do noot look for Webkit and qt declarative on qt version 5.6 or newer
-      if(${QT_VERSION_MINOR} GREATER 5)
-          find_package (Qt5Widgets QUIET)
-          find_package (Qt5Gui QUIET)
-          find_package (Qt5OpenGL QUIET)
-          find_package (Qt5Network QUIET)
-          find_package (Qt5Script QUIET)
-          find_package (Qt5ScriptTools QUIET)
-          find_package (Qt5Sql QUIET)
-          find_package (Qt5Xml QUIET)
-          find_package (Qt5XmlPatterns QUIET)
-          find_package (Qt5Help QUIET)
-          find_package (Qt5UiTools QUIET)
-          find_package (Qt5Concurrent QUIET)
-          find_package (Qt5PrintSupport QUIET)
-          find_package (Qt5Svg QUIET)
-      elseif(${QT_VERSION_MINOR} GREATER 5)
-          find_package (Qt5Declarative QUIET)
-          find_package (Qt5Widgets QUIET)
-          find_package (Qt5Gui QUIET)
-          find_package (Qt5OpenGL QUIET)
-          find_package (Qt5Network QUIET)
-          find_package (Qt5Script QUIET)
-          find_package (Qt5ScriptTools QUIET)
-          find_package (Qt5Sql QUIET)
-          find_package (Qt5Xml QUIET)
-          find_package (Qt5XmlPatterns QUIET)
-          find_package (Qt5Help QUIET)
-          find_package (Qt5WebKit QUIET)
-          find_package (Qt5UiTools QUIET)
-          find_package (Qt5Concurrent QUIET)
-          find_package (Qt5PrintSupport QUIET)
-          find_package (Qt5Svg QUIET)
-      endif(${QT_VERSION_MINOR} GREATER 5)
-
-      if (NOT WIN32 AND NOT APPLE)
-         find_package (Qt5X11Extras QUIET)
-      endif ()
+      endif()    
+    endif(Qt5Core_FOUND AND WIN32)
+    
+    find_package (Qt5Declarative QUIET)
+    find_package (Qt5Widgets QUIET)    
+    find_package (Qt5Gui QUIET)
+    find_package (Qt5OpenGL QUIET)
+    find_package (Qt5Network QUIET)
+    find_package (Qt5Script QUIET)
+    find_package (Qt5ScriptTools QUIET)
+    find_package (Qt5Sql QUIET)
+    find_package (Qt5Xml QUIET)
+    find_package (Qt5XmlPatterns QUIET)
+    find_package (Qt5Help QUIET)
+    find_package (Qt5WebKit QUIET)
+    find_package (Qt5UiTools QUIET)
+    find_package (Qt5Concurrent QUIET)
+    find_package (Qt5PrintSupport QUIET)
+    find_package (Qt5Svg QUIET)
+    
+    if (NOT WIN32 AND NOT APPLE)
+    	find_package (Qt5X11Extras QUIET)
+    endif ()
+    
 
-      if(${QT_VERSION_MINOR} GREATER 5)
-          if (Qt5Core_FOUND AND Qt5Widgets_FOUND
-            AND Qt5Gui_FOUND AND Qt5OpenGL_FOUND AND Qt5Network_FOUND
-            AND Qt5Script_FOUND AND Qt5ScriptTools_FOUND AND Qt5Sql_FOUND
-            AND Qt5Xml_FOUND AND Qt5XmlPatterns_FOUND AND Qt5Help_FOUND
-            AND Qt5UiTools_FOUND AND Qt5Concurrent_FOUND
-            AND Qt5PrintSupport_FOUND)
-            set (QT5_FOUND TRUE)
-          endif()
-      elseif(${QT_VERSION_MINOR} GREATER 5)
-          if (Qt5Core_FOUND AND Qt5Declarative_FOUND AND Qt5Widgets_FOUND
-            AND Qt5Gui_FOUND AND Qt5OpenGL_FOUND AND Qt5Network_FOUND
-            AND Qt5Script_FOUND AND Qt5ScriptTools_FOUND AND Qt5Sql_FOUND
-            AND Qt5Xml_FOUND AND Qt5XmlPatterns_FOUND AND Qt5Help_FOUND
-            AND Qt5WebKit_FOUND AND Qt5UiTools_FOUND AND Qt5Concurrent_FOUND
-            AND Qt5PrintSupport_FOUND)
-            set (QT5_FOUND TRUE)
-          endif()
-      endif(${QT_VERSION_MINOR} GREATER 5)
-    endif(Qt5Core_FOUND)
+    if (Qt5Core_FOUND AND Qt5Declarative_FOUND AND Qt5Widgets_FOUND
+      AND Qt5Gui_FOUND AND Qt5OpenGL_FOUND AND Qt5Network_FOUND
+      AND Qt5Script_FOUND AND Qt5ScriptTools_FOUND AND Qt5Sql_FOUND
+      AND Qt5Xml_FOUND AND Qt5XmlPatterns_FOUND AND Qt5Help_FOUND
+      AND Qt5WebKit_FOUND AND Qt5UiTools_FOUND AND Qt5Concurrent_FOUND
+      AND Qt5PrintSupport_FOUND)