Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
CoMISo
CoMISo
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CoMISo
  • CoMISoCoMISo
  • Issues
  • #8

Closed
Open
Opened Jan 15, 2021 by Martin Heistermann@mheistermannDeveloper

"VERSION" file causes include errors on MacOS

The following combination breaks my build on MacOS:

  • setting the CoMISo project root dir as include dir: https://graphics.rwth-aachen.de:9000/CoMISo/CoMISo/-/blob/68e7fb6eb836d1af0211341d32cf965e2b4ec5de/CMakeLists.txt#L73
  • the "VERSION" file in the project root
  • <version> being a standard library header in C++20, which is included transitively in LLVM's libc++
  • MacOS with (default) case-insensitive file system

This leads to VERSION being #include'd, which clearly won't work.

VERSION is used by vci_get_version() in cmake-library/VCI/VCICommon.cmake

I have multiple suggestions on how to fix this:

  • Avoiding use of vci_get_version in CMake in favor of just setting the version in the project() call, then deleting VERSION. If you would merge this change, I'd be up for implementing it.
  • Reorganizing the source so that we don't have to add the CoMISo root (or worse, its parent directory!) as include dir. For example moving everything to a src dir, or even splitting into src and include/CoMISo (for public headers). Not sure how to handle Base/, this is maybe a task someone with insight into how CoMISo is used at Autodesk could perform better
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: CoMISo/CoMISo#8